Gilad Chaplik has posted comments on this change.

Change subject: webadmin: dc->logical network add/new design
......................................................................


Patch Set 8: (2 inline comments)

comments inline (sorry :-) )

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterNetworkPopupView.java
Line 113:                 redraw();
please remove this.
the table need to get it's data via setting the edit method.

@Override
    public void edit(DataCenterNetworkModel object) {
        Driver.driver.edit(object);
        table.edit(object.getList());
    }

and don't forget to flush :-)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterNetworkPopupView.ui.xml
Line 85:                                        <g:VerticalPanel>               
                
remove TWS

--
To view, visit http://gerrit.ovirt.org/5095
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c31ce6a9b6907cab04c5f3041808945fb40885b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to