Gilad Chaplik has posted comments on this change.

Change subject: webadmin: cluster->Logical network->assign/detach- redesign
......................................................................


Patch Set 4: (1 inline comment)

comments inline.

Tested functionally, issues with 'required all' checkbox behaviour - it's 
checked although no all checkboxes in column are checked.

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
Line 58:                        networks.redraw();
same as previous patch :)
remove this code, and set the dataProvider of the widget in edit(model) method

--
To view, visit http://gerrit.ovirt.org/5225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43df91cf11846af00130440f30b38e2288fe5047
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to