Francesco Romani has posted comments on this change. Change subject: core, webadmin: report QEMU live snapshot support ......................................................................
Patch Set 3: (2 comments) Allon: followup patches with disabling are expected, but not in the near term... Omer: followup separate patch for rest-api is already in the pipeline and will published ASAP. http://gerrit.ovirt.org/#/c/27677/3/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 2864: <value>-1</value> Line 2865: <null /> Line 2866: <value>2</value> Line 2867: <value>true</value> Line 2868: <value>true</value> > Might be worth while having one of these "false" instead of "true", jut to Will fix. Line 2869: </row> Line 2870: </table> Line 2871: Line 2872: <table name="vds_statistics"> http://gerrit.ovirt.org/#/c/27677/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 439: Line 440: if (xmlRpcStruct.containsKey(VdsProperties.liveSnapshotSupport)) { Line 441: vds.setLiveSnapshotSupport(AssignBoolValue(xmlRpcStruct, VdsProperties.liveSnapshotSupport)); Line 442: } else { Line 443: vds.setLiveSnapshotSupport(true); // assume supported for backward compatibility > actually i think it might be more correct to leave old value in case vdsm d Will fix Line 444: } Line 445: } Line 446: Line 447: public static void checkTimeDrift(VDS vds, Map<String, Object> xmlRpcStruct) { -- To view, visit http://gerrit.ovirt.org/27677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a34967eeeefcaabf2fad21192b7045f9ecc07e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
