Omer Frenkel has posted comments on this change. Change subject: core, webadmin: report QEMU live snapshot support ......................................................................
Patch Set 3: (1 comment) in addition to Allon's comments, what about returning this value in rest api? (better in separate patch, though) http://gerrit.ovirt.org/#/c/27677/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 439: Line 440: if (xmlRpcStruct.containsKey(VdsProperties.liveSnapshotSupport)) { Line 441: vds.setLiveSnapshotSupport(AssignBoolValue(xmlRpcStruct, VdsProperties.liveSnapshotSupport)); Line 442: } else { Line 443: vds.setLiveSnapshotSupport(true); // assume supported for backward compatibility actually i think it might be more correct to leave old value in case vdsm doest tell us anything, in general it should be true because it is set in the ctor. Line 444: } Line 445: } Line 446: Line 447: public static void checkTimeDrift(VDS vds, Map<String, Object> xmlRpcStruct) { -- To view, visit http://gerrit.ovirt.org/27677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a34967eeeefcaabf2fad21192b7045f9ecc07e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
