Martin Mucha has posted comments on this change. Change subject: core: util for removing overlaps in ranges ......................................................................
Patch Set 18: (3 comments) answers. http://gerrit.ovirt.org/#/c/26403/18/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DisjointRangesTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DisjointRangesTest.java: Line 14: import org.junit.runner.RunWith; Line 15: import org.junit.runners.Parameterized; Line 16: Line 17: @RunWith(Parameterized.class) Line 18: public class DisjointRangesTest { > Please run the formatter on the code (on all your changes in all you patche Done Line 19: Line 20: private List<LongRange> inputRanges; Line 21: private final List<LongRange> expectedRanges; Line 22: Line 51: } Line 52: Line 53: @Test Line 54: public void test() throws Exception { Line 55: final Random rnd = new Random(0); > You should use RandomUtils with RandomUtilsSeedingRule Done Line 56: final int iterations = 20; Line 57: Line 58: for(int i = 0; i < iterations; i++) { Line 59: Collections.shuffle(inputRanges, rnd); Line 54: public void test() throws Exception { Line 55: final Random rnd = new Random(0); Line 56: final int iterations = 20; Line 57: Line 58: for(int i = 0; i < iterations; i++) { > No need for iterations Done Line 59: Collections.shuffle(inputRanges, rnd); Line 60: doTest(inputRanges); Line 61: } Line 62: } -- To view, visit http://gerrit.ovirt.org/26403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7dbacd11b610a5885d574356a695c6e879dcdbc Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
