Ravi Nori has posted comments on this change. Change subject: aaa: Introduce usage of Acct ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/27070/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java: Line 110: return; Line 111: } Line 112: ExtMap authRecord = new ExtMap(); Line 113: ExtMap principalRecord = AuthzUtils.fetchPrincipalRecord(authz, authRecord); Line 114: if (principalRecord == null) { Should we check for principalRecord being empty? Line 115: log.info( Line 116: "Can't login user \"{}\" with authentication profile \"{}\" because the user doesn't exist in the " + Line 117: "directory.", Line 118: loginName, profileName Line 122: return; Line 123: } Line 124: Line 125: DirectoryUser directoryUser = AuthzUtils.mapPrincipalRecord(authz, principalRecord); Line 126: I think the if (directoryUser == null) check should be here Line 127: // Check that the user exists in the database, if it doesn't exist then we need to add it now: Line 128: DbUserDAO dbUserDao = DbFacade.getInstance().getDbUserDao(); Line 129: dbUser = dbUserDao.getByExternalId(AuthzUtils.getName(authz), directoryUser.getId()); Line 130: if (dbUser == null) { http://gerrit.ovirt.org/#/c/27070/7/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java: Line 70: if (principal.getDomain() == null) { Line 71: return loginFailure(principal, NO_DOMAIN); Line 72: } Line 73: getCurrentSession(false); Line 74: Can you please explain why this was added here Line 75: LoginUserParameters params = new LoginUserParameters( Line 76: principal.getDomain(), Line 77: principal.getUser(), Line 78: principal.getSecret() -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
