Daniel Erez has posted comments on this change. Change subject: core: Use import command to register a VM ......................................................................
Patch Set 30: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/27247/30/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 2894: Line 2895: @DefaultStringValue("Cannot ${action} ${type}. The VM Network Interface is plugged to a running VM.") Line 2896: String ACTION_TYPE_FAILED_CANNOT_REMOVE_ACTIVE_DEVICE(); Line 2897: Line 2898: @DefaultStringValue("Cannot ${action} ${type}. Unregistered VM can not be collapsed.") +1 for Liron's suggestion at: http://gerrit.ovirt.org/#/c/27247/25/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 2899: String ACTION_TYPE_FAILED_IMPORT_UNREGISTERED_NOT_COLLAPSED(); Line 2900: Line 2901: @DefaultStringValue("Cannot ${action} ${type}. Enabling both Virt and Gluster services is not allowed.") Line 2902: String VDS_GROUP_ENABLING_BOTH_VIRT_AND_GLUSTER_SERVICES_NOT_ALLOWED(); -- To view, visit http://gerrit.ovirt.org/27247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ee64651eb614feb6ac9d7fde88a4ee6348aff06 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches