Liron Ar has posted comments on this change. Change subject: core: Use import command to register a VM ......................................................................
Patch Set 27: (1 comment) http://gerrit.ovirt.org/#/c/27247/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java: Line 78: getParameters().setStoragePoolId(getVdsGroup().getStoragePoolId()); Line 79: super.init(parameters); Line 80: } Line 81: Line 82: private void initUnregisteredVM() { add CDA to check if the init succeeded, if it fails you'll end up with null vm which will cause to an NPE. Line 83: VM vmFromConfiguration = null; Line 84: OvfHelper ovfHelper = new OvfHelper(); Line 85: ovfEntityData = Line 86: getUnregisteredOVFDataDao().getByEntityIdAndStorageDomain(getParameters().getContainerId(), -- To view, visit http://gerrit.ovirt.org/27247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ee64651eb614feb6ac9d7fde88a4ee6348aff06 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
