Lior Vernia has posted comments on this change. Change subject: webadmin: Pass map instead of strings to KeyValueModel ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27386/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 280: } Line 281: Line 282: Line 283: }; Line 284: Frontend.getInstance().runQuery(VdcQueryType.GetVmCustomProperties, > Done Actually, this belongs in the next patch, where I introduce custom properties utils into Frontend. So if you don't mind, I'll revert the change here and put it there. Line 285: new VdcQueryParametersBase().withoutRefresh(), callback); Line 286: } Line 287: Line 288: public static void initDefaultOSes() { -- To view, visit http://gerrit.ovirt.org/27386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic57b3157960e829d43073c1614647b25a3b6a139 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
