Lior Vernia has posted comments on this change. Change subject: webadmin: Pass map instead of strings to KeyValueModel ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27386/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 274: Line 275: callback.converterCallback = new IAsyncConverter() { Line 276: @Override Line 277: public Object Convert(Object source, AsyncQuery _asyncQuery) { Line 278: return (source != null) ? (Map<Version, Map<String, String>>) source > I"m not sure I understand your comment... VmPropertiesUtil.getAllVmProperties() was modified in this patch as well. Line 279: : new HashMap<Version, Map<String, String>>(); Line 280: } Line 281: Line 282: -- To view, visit http://gerrit.ovirt.org/27386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic57b3157960e829d43073c1614647b25a3b6a139 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
