Alon Bar-Lev has posted comments on this change.

Change subject: fklsnr: Introduce standalone fence_kdump listener
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/27201/12/packaging/services/ovirt-fence-kdump-listener/listener.py
File packaging/services/ovirt-fence-kdump-listener/listener.py:

Line 191:         ):
Line 192:             self._dao.update_heartbeat()
Line 193:             self._lastHeartbeat = datetime.datetime.utcnow()
Line 194: 
Line 195:     def _save_sessions(self):
> Currently we update heartbeat and dirty sessions per heartbeat interval (ea
yes, I want heartbeat interval and database sync at different intervals.

I think that heartbeat can be 60 seconds.

I think that database sync can be 30 seconds... but you say 5, I am ok.

anyway, the values are at the config file.

you can even put:

 xxx_interval="${yyy_interval}"

to make them the same.
Line 196:         # update db state for all updated sessions
Line 197:         for session in self._sessions.values():
Line 198:             if session['dirty']:
Line 199:                 rows_updated = self._dao.update_vds_kdump_status(


-- 
To view, visit http://gerrit.ovirt.org/27201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to