Alon Bar-Lev has posted comments on this change. Change subject: fklsnr: Introduce standalone fence_kdump listener ......................................................................
Patch Set 12: (3 comments) http://gerrit.ovirt.org/#/c/27201/12/packaging/services/ovirt-fence-kdump-listener/listener.py File packaging/services/ovirt-fence-kdump-listener/listener.py: Line 191: ): Line 192: self._dao.update_heartbeat() Line 193: self._lastHeartbeat = datetime.datetime.utcnow() Line 194: Line 195: def _save_sessions(self): > 1) As I wrote above currently we do 2 db inserts/updates per dumping host ( 1. there should be single interval for database update, I did not notice you have two... if there are, please drop one. 2. I gave 30 seconds as example, best to have this as parameter. I think that detection of dumps may take time anyway, we will tune that in future, even if now you provide 5 seconds interval. it should be simple to add this interval so we can have all parameter externalized, better to do this now. Line 196: # update db state for all updated sessions Line 197: for session in self._sessions.values(): Line 198: if session['dirty']: Line 199: rows_updated = self._dao.update_vds_kdump_status( Line 208: "address '{address}'." Line 209: ).format( Line 210: address=session['address'][0], Line 211: ) Line 212: ) > It doesn't matter how do you call it :-) but what is not working? an machine sending different protocol to our port... why do we care? Line 213: # set status to finished to be removed in next step Line 214: session['status'] = self.SESSION_STATE_CLOSED Line 215: Line 216: if session['status'] == self.SESSION_STATE_FINISHED: Line 237: Line 238: self._afterFirstDbSync = True Line 239: Line 240: def _db_sync(self): Line 241: if self._db_manager.validate_connection(): > Right, I forgot about this scenario, even I don't think the db down will ha I do not follow... but please add reconnect interval. Line 242: self._db_connection_valid = True Line 243: try: Line 244: self._heartbeat() Line 245: self._save_sessions() -- To view, visit http://gerrit.ovirt.org/27201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
