Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: Introduce plugin for fence_kdump listener
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/27486/7/packaging/setup/plugins/ovirt-engine-common/base/core/fence_kdump_listener.py
File 
packaging/setup/plugins/ovirt-engine-common/base/core/fence_kdump_listener.py:

Line 19: """fence_kdump listener plugin."""
Line 20: 
Line 21: 
Line 22: import gettext
Line 23: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-setup')
> please move call to dgettext after import section in all files.
please ignore above comment.
Line 24: 
Line 25: 
Line 26: from otopi import util
Line 27: from otopi import plugin


-- 
To view, visit http://gerrit.ovirt.org/27486
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to