Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Introduce plugin for fence_kdump listener ......................................................................
Patch Set 10: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27486/10/packaging/firewalld/ovirt-engine/ovirt-fence-kdump-listener.xml.in File packaging/firewalld/ovirt-engine/ovirt-fence-kdump-listener.xml.in: Line 1: <?xml version="1.0" encoding="utf-8"?> Line 2: <service> Line 3: <short>ovirt-fence-kdump-listener</short> Line 4: <description>oVirt configured fence_kdump listener service</description> Line 5: <port protocol="udp" port="7410"/> if we want to customize this we can of @FKDUMP_LISTEN_PORT@ and take it from environment, move the default to the plugin and allow override, similar to our other ports. however, this will make it somewhat more complex as we also need to create configuration file with the port number... not sure that this is important right now. but if we expect anyone to change the port number, then every run of setup will block it... :) -- To view, visit http://gerrit.ovirt.org/27486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
