anmolbabu has posted comments on this change.

Change subject: webadmin : add pdf export button to volume profile
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28085/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java:

Line 289:     @Override
Line 290:     public void executeCommand(UICommand command) {
Line 291:         if (command.getName().equalsIgnoreCase("export_to_pdf")) 
{//$NON-NLS-1$
Line 292:             GlusterVolumeProfileInfo profileInfo = getProfileInfo();
Line 293:             GlusterVolumeCreatePdfParameters pdfParameters = new 
GlusterVolumeCreatePdfParameters(profileInfo, "", 
"admin");//$NON-NLS-1$//$NON-NLS-2$
> User id getting hard coded here ??
i am just trying to check if this works(pdf is created or not).I'll use the 
CurrentUser as you had told me.
Line 294:             
Frontend.getInstance().runAction(VdcActionType.GlusterVolumeProfilePdfExport, 
pdfParameters, true);
Line 295:         }
Line 296:     }


-- 
To view, visit http://gerrit.ovirt.org/28085
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I506efc1c626059811c8e69d8232145430b3ec963
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to