Shubhendu Tripathi has posted comments on this change. Change subject: webadmin : add pdf export button to volume profile ......................................................................
Patch Set 3: (2 comments) Check the test case failures. http://gerrit.ovirt.org/#/c/28085/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java: Line 289: @Override Line 290: public void executeCommand(UICommand command) { Line 291: if (command.getName().equalsIgnoreCase("export_to_pdf")) {//$NON-NLS-1$ Line 292: GlusterVolumeProfileInfo profileInfo = getProfileInfo(); Line 293: GlusterVolumeCreatePdfParameters pdfParameters = new GlusterVolumeCreatePdfParameters(profileInfo, "", "admin");//$NON-NLS-1$//$NON-NLS-2$ User id getting hard coded here ?? Line 294: Frontend.getInstance().runAction(VdcActionType.GlusterVolumeProfilePdfExport, pdfParameters, true); Line 295: } Line 296: } http://gerrit.ovirt.org/#/c/28085/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 550: getConfirmWindow().stopProgress(); Line 551: setConfirmWindow(null); Line 552: } else if (command.getName().equalsIgnoreCase("export_to_pdf")) {//$NON-NLS-1$ Line 553: GlusterVolumeProfileInfo profileInfo = ((VolumeProfileStatisticsModel) getWindow()).getProfileInfo(); Line 554: GlusterVolumeCreatePdfParameters pdfParameters = new GlusterVolumeCreatePdfParameters(profileInfo, "", "admin");//$NON-NLS-1$//$NON-NLS-2$ User id hardcoded Line 555: Frontend.getInstance().runAction(VdcActionType.GlusterVolumeProfilePdfExport, pdfParameters, true); Line 556: } Line 557: } Line 558: -- To view, visit http://gerrit.ovirt.org/28085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I506efc1c626059811c8e69d8232145430b3ec963 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
