Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: support distro without jboss-as 7 ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/28064/2/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 940 Line 941 Line 942 Line 943 Line 944 > we do not need this comment twice :) I'll remove, no need of another patch just for this minor change :-) Line 195: Requires: %{name}-webadmin-portal = %{version}-%{release} Line 196: Requires: %{name}-websocket-proxy >= %{version}-%{release} Line 197: Requires: java Line 198: Requires: java-1.7.0-openjdk >= 1:1.7.0.9-2.3.3.2 Line 199: Requires: %{jboss} > sort? :) well, jboss is sorted :-) or do you mean to move this as first since %{jboss} comes first before %{name} ? Line 200: Requires: jpackage-utils Line 201: Requires: ovirt-image-uploader >= 3.3.0 Line 202: Requires: ovirt-iso-uploader >= 3.3.0 Line 203: Requires: ovirt-log-collector >= 3.3.0 Line 203: Requires: ovirt-log-collector >= 3.3.0 Line 204: Requires: postgresql-server >= 8.4.7 Line 205: Requires: ws-commons-util Line 206: Requires: yum-plugin-versionlock Line 207: > ? sorry, leftover Line 208: Line 209: %if 0%{?fedora} Line 210: %if %{fedora} >= 19 Line 211: Requires: apache-commons-compress -- To view, visit http://gerrit.ovirt.org/28064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icef92a1f22e6f88458d1624429dff57a9817192f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches