Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: support distro without jboss-as 7 ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28064/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 203: Line 204: %if %{ovirt_provides_jboss} Line 205: Requires: ovirt-engine-jboss-as >= 7.1.1 Line 206: %else Line 207: Requires: jboss-as >= 7.1.1-9.3 > tabs? Done Line 208: %endif Line 209: Line 210: Line 211: %if 0%{?fedora} Line 951: Line 952: %config %{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging.conf Line 953: %if %{ovirt_provides_jboss} Line 954: %config %{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging-jboss.conf Line 955: %endif > please put conditional after non conditionals so we can sort() easily... Done Line 956: %{_bindir}/engine-upgrade-check Line 957: %{engine_data}/conf/ovirt-engine-proxy.conf.v2.in Line 958: %{engine_data}/conf/ovirt-engine-root-redirect.conf.in Line 959: %{engine_data}/firewalld/ovirt-engine/ -- To view, visit http://gerrit.ovirt.org/28064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icef92a1f22e6f88458d1624429dff57a9817192f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
