ShaoHe Feng has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
......................................................................
Patch Set 5: (7 inline comments)
....................................................
File src/codegen/genparams.py
Line 124: cmd = " ".join([argv for argv in args])
agree.
Line 159: rule = '|'.join([rule1, rule2, attrrule])
oh, attrrule should be not here.
Line 284: if getIndentsOfString(symbols[i]) <= indents:
the indents <= class, means find find another class or function does not belong
to this class
Line 355: preSpace += " "
" " * indents is more better
Line 504: (classname, lastAttr))
yes.
Line 516: logging.info("[INFO] add import module")
yes.
Line 538: filelist[begidx:begidx] = vallist
yes.
--
To view, visit http://gerrit.ovirt.org/4880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I916f63f1ac68ce2e31456a90c1291997f671af99
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
