Maor Lipchuk has posted comments on this change. Change subject: core: Add snapshot to the OVF generation ......................................................................
Patch Set 27: (1 comment) http://gerrit.ovirt.org/#/c/25947/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java: Line 388: Line 389: if (currentDbGeneration == null) { Line 390: log.warnFormat("currentDbGeneration of VM (name: {0}, id: {1}) is null, probably because the VM was deleted during the run of OvfDataUpdater.", Line 391: vm.getName(), Line 392: vm.getId()); > this change seems irrelevant for this patch, let's leave it as it was. I will put this in a seperate patch Line 393: } else if (vm.getStaticData().getDbGeneration() == currentDbGeneration) { Line 394: proccessedOvfConfigurationsInfo.add(buildMetadataDictionaryForVm(vm, vmsAndTemplateMetadata, vmImages)); Line 395: proccessedIdsInfo.add(vm.getId()); Line 396: proccessedOvfGenerationsInfo.add(vm.getStaticData().getDbGeneration()); -- To view, visit http://gerrit.ovirt.org/25947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ba05c2e362fb9b22d6b4fb5a14698ad99d7bd1e Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
