Maor Lipchuk has posted comments on this change. Change subject: core: Add snapshot to the OVF generation ......................................................................
Patch Set 23: (3 comments) http://gerrit.ovirt.org/#/c/25947/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java: Line 373: updateVmDisksFromDb(vm); Line 374: if (!verifyImagesStatus(vm.getDiskList())) { Line 375: continue; Line 376: } Line 377: ArrayList<DiskImage> vmImages = getVmImagesFromDb(vm); > nit - spacing.. no need Line 378: if (!verifyImagesStatus(vmImages)) { Line 379: continue; Line 380: } Line 381: vm.setSnapshots(getSnapshotDao().getAllWithConfiguration(vm.getId())); Line 384: } Line 385: Line 386: loadVmData(vm); Line 387: Long currentDbGeneration = getVmStaticDao().getDbGeneration(vm.getId()); Line 388: // currentDbGeneration can be null in case that the vm was deleted during the run of OvfDataUpdater. > is it a relevant scenario for logging? done Line 389: if (currentDbGeneration != null && vm.getStaticData().getDbGeneration() == currentDbGeneration) { Line 390: proccessedOvfConfigurationsInfo.add(buildMetadataDictionaryForVm(vm, vmsAndTemplateMetadata, vmImages)); Line 391: proccessedIdsInfo.add(vm.getId()); Line 392: proccessedOvfGenerationsInfo.add(vm.getStaticData().getDbGeneration()); Line 427: Line 428: /** Line 429: * Returns true if none of the given disks is in status 'LOCKED', otherwise false. Line 430: */ Line 431: protected boolean verifyImagesStatus(List<DiskImage> diskImages) { > can 'DiskImagesValidator -> diskImagesNotLocked' be used instead? Could be used in a later phase Line 432: for (DiskImage diskImage : diskImages) { Line 433: if (diskImage.getImageStatus() == ImageStatus.LOCKED) { Line 434: return false; Line 435: } -- To view, visit http://gerrit.ovirt.org/25947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ba05c2e362fb9b22d6b4fb5a14698ad99d7bd1e Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
