Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Not show aid instruction on non-editable cluster 
policy dialog
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/27975/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-05-21 16:44:49 +0300
Line 4: Commit:     Artyom Lukianov <aluki...@redhat.com>
Line 5: CommitDate: 2014-05-21 16:55:58 +0300
Line 6: 
Line 7: webadmin: Not show aid instruction on non-editable cluster policy dialog
iinm, header limit is 50 chars.
Line 8: 
Line 9: Change-Id: Iab405ae44b9ad74984cc343dfee12ed28a85e302
Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=995571


http://gerrit.ovirt.org/#/c/27975/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java:

Line 155:     private void localize(ApplicationConstants constants) {
Line 156:         nameEditor.setLabel(constants.clusterPolicyNameLabel());
Line 157:         
descriptionEditor.setLabel(constants.clusterPolicyDescriptionLabel());
Line 158:         
filterExplanationMessage.setText(constants.clusterPolicyExplanationMessage());
Line 159:         
weightExplanationMessage.setText(constants.clusterPolicyExplanationMessage());
> * same text for both?
btw, what is the text?
Line 160:     }
Line 161: 
Line 162:     public boolean showClusterPolicyPropertiesZone(final 
NewClusterPolicyModel model) {
Line 163:         if (!model.getCustomProperties().isEmpty()) {


-- 
To view, visit http://gerrit.ovirt.org/27975
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab405ae44b9ad74984cc343dfee12ed28a85e302
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <aluki...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to