Gilad Chaplik has posted comments on this change. Change subject: webadmin: Not show aid instruction on non-editable cluster policy dialog ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/27975/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java: Line 155: private void localize(ApplicationConstants constants) { Line 156: nameEditor.setLabel(constants.clusterPolicyNameLabel()); Line 157: descriptionEditor.setLabel(constants.clusterPolicyDescriptionLabel()); Line 158: filterExplanationMessage.setText(constants.clusterPolicyExplanationMessage()); Line 159: weightExplanationMessage.setText(constants.clusterPolicyExplanationMessage()); * same text for both? * I'd prefer the blue icon * what about balance and properties? Line 160: } Line 161: Line 162: public boolean showClusterPolicyPropertiesZone(final NewClusterPolicyModel model) { Line 163: if (!model.getCustomProperties().isEmpty()) { Line 253: String text = ""; //$NON-NLS-1$ Line 254: if (model.getClusterPolicy().isLocked()){ Line 255: filterExplanationMessage.setText(text); Line 256: weightExplanationMessage.setText(text); Line 257: } if it locked I'd want to see another message. Line 258: if (!selectedItem.isInternal()) { Line 259: text = constants.externalPolicyUnitLabel() + " "; //$NON-NLS-1$ Line 260: } Line 261: if (!selectedItem.isEnabled()) { -- To view, visit http://gerrit.ovirt.org/27975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab405ae44b9ad74984cc343dfee12ed28a85e302 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <aluki...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
