Eli Mesika has posted comments on this change. Change subject: oVirt: Provide informations about fencing in RHEV-M ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/27706/5//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-05-14 15:25:12 +0300 Line 4: Commit: Eli Mesika <emes...@redhat.com> Line 5: CommitDate: 2014-05-18 07:26:53 -0400 Line 6: Line 7: oVirt: Provide informations about fencing in RHEV-M > I think Yair meant: Done Line 8: Line 9: This patch adds missing logging in both log file and audit log for Line 10: fencing flow. Line 11: http://gerrit.ovirt.org/#/c/27706/5/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 606: VDS_ALERT_FENCE_OPERATION_SKIPPED=Host ${VdsName} became non responsive. It has no power management configured. Please check the host status, manually reboot it, and click "Confirm Host Has Been Rebooted" Line 607: VDS_ALERT_FENCE_NO_PROXY_HOST=There is no other host in the data center that can be used to test the power management settings. Line 608: VDS_ALERT_FENCE_STATUS_VERIFICATION_FAILED=Failed to verify Host ${Host} ${Status} status, Please ${Status} Host ${Host} manually. Line 609: VDS_ALERT_SECONDARY_AGENT_USED_FOR_FENCE_OPERATION=Secondary fence agent was used to ${Operation} Host ${VdsName} Line 610: VDS_HOST_NOT_RESPONDING_CONNECTING=Host ${VdsName} is not responding, Host will be in Connecting state for a grace period of ${Seconds} Seconds and after that an attempt to fence the Host will be issued. > I would correct it a bit: Done Line 611: TASK_STOPPING_ASYNC_TASK=Stopping async task ${CommandName} that started at ${Date} Line 612: REFRESH_REPOSITORY_IMAGE_LIST_FAILED=Refresh image list failed for domain(s): ${imageDomains}. Please check domain activity. Line 613: REFRESH_REPOSITORY_IMAGE_LIST_SUCCEEDED=Refresh image list succeeded for domain(s): ${imageDomains} Line 614: REFRESH_REPOSITORY_IMAGE_LIST_INCOMPLETE=Refresh image list probably incomplete for domain ${imageDomain}, only ${imageListSize} images discovered. http://gerrit.ovirt.org/#/c/27706/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 670: */ Line 671: public boolean handleNetworkException(VDSNetworkException ex, VDS vds) { Line 672: if (vds.getStatus() != VDSStatus.Down) { Line 673: long timeoutToFence = calcTimeoutToFence(vds.getVmCount(), vds.getSpmStatus()); Line 674: log.warnFormat("Host {0} is not responding, Host will be in Connecting state for a grace period of {1} Sec and after that an attempt to fence the Host will be issued.", vds.getName(), TimeUnit.MILLISECONDS.toSeconds(timeoutToFence)); > Same here: Done Line 675: AuditLogableBase logable = new AuditLogableBase(); Line 676: logable.setVdsId(vds.getId()); Line 677: logable.addCustomValue("Seconds", Long.toString(TimeUnit.MILLISECONDS.toSeconds(timeoutToFence))); Line 678: AuditLogDirector.log(logable, AuditLogType.VDS_HOST_IN_CONNECTING_STATE); -- To view, visit http://gerrit.ovirt.org/27706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f9aa1711f9b47b7a5a3b805da4002e3fbbe24be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
