Alissa Bonas has uploaded a new change for review.
Change subject: core: remove 'final' keyword from private methods
......................................................................
core: remove 'final' keyword from private methods
Change-Id: I0871b3853b287d5e8918f7d7e38b99895e575f77
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
5 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/27794/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
index b79f1c3..0bfa91a 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
@@ -42,7 +42,7 @@
user = initUser();
}
- private final VdcQueryType initQueryType() {
+ private VdcQueryType initQueryType() {
try {
String name = getClass().getSimpleName();
name = name.substring(0, name.length() - QuerySuffix.length());
@@ -52,7 +52,7 @@
}
}
- private final DbUser initUser() {
+ private DbUser initUser() {
return
SessionDataContainer.getInstance().addUserToThreadContext(parameters.getSessionId(),
parameters.getRefresh());
}
@@ -100,7 +100,7 @@
* @return <code>true</code> if the query is OK (i.e., the issuing user has
enough permissions to execute it), or
* <code>false</code> otherwise.
*/
- private final boolean validatePermissions() {
+ private boolean validatePermissions() {
// If the user requests filtered execution, his permissions are
inconsequential.
// If the query supports filtering it should be allowed, and if not -
not.
if (parameters.isFiltered()) {
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
index 5d5e378..1637fac 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
@@ -234,12 +234,12 @@
return genericSearch(getDbFacade().getVmTemplateDao(), true);
}
- private final <T extends IVdcQueryable> List<T> genericSearch(final
SearchDAO<T> dao,
+ private <T extends IVdcQueryable> List<T> genericSearch(final SearchDAO<T>
dao,
final boolean useCache) {
return genericSearch(dao, useCache, null);
}
- private final <T extends IVdcQueryable> List<T> genericSearch(final
SearchDAO<T> dao,
+ private <T extends IVdcQueryable> List<T> genericSearch(final SearchDAO<T>
dao,
final boolean useCache,
final Filter<T> filter) {
final QueryData data = initQueryData(useCache);
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
index 437e733..72f5dcb 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
@@ -208,7 +208,7 @@
return model;
}
- private final <T> Response fetchCreatedEntity(IResolver<T, Q>
entityResolver,
+ private <T> Response fetchCreatedEntity(IResolver<T, Q> entityResolver,
boolean block,
Class<? extends BaseResource> suggestedParentType,
VdcReturnValueBase createResult) {
@@ -250,7 +250,7 @@
return createResult;
}
- private final R mapEntity(Class<? extends BaseResource>
suggestedParentType, Q created) {
+ private R mapEntity(Class<? extends BaseResource> suggestedParentType, Q
created) {
R model = map(created);
model = deprecatedPopulate(model, created);
model = doPopulate(model, created);
diff --git
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
index 875db67..b8e7a96 100644
---
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
+++
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
@@ -70,7 +70,7 @@
return messages;
}
- private final List<String> translate(List<String> errorMsg, boolean
changeIfNotFound, Locale locale) {
+ private List<String> translate(List<String> errorMsg, boolean
changeIfNotFound, Locale locale) {
List<String> translatedMessages = doTranslation(errorMsg,
changeIfNotFound, locale);
return ResolveMessages(translatedMessages);
}
@@ -130,7 +130,7 @@
return translate(errorMsg, true, locale);
}
- private final String translate(String errorMsg, boolean changeIfNotFound,
Locale locale) {
+ private String translate(String errorMsg, boolean changeIfNotFound, Locale
locale) {
String ret = "";
Map<String, String> messages = getMessages(locale);
if (messages != null && messages.containsKey(errorMsg)) {
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
index 747c6f1..eaeb667 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
@@ -201,7 +201,7 @@
* the string that may be a dynamic variable
* @return true if input is dynamic variable, false otherwise.
*/
- private final boolean isDynamicVariable(String strMessage) {
+ private boolean isDynamicVariable(String strMessage) {
return strMessage.startsWith("$"); //$NON-NLS-1$
}
--
To view, visit http://gerrit.ovirt.org/27794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0871b3853b287d5e8918f7d7e38b99895e575f77
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
