Sahina Bose has posted comments on this change. Change subject: engine: Improve test assert messages ......................................................................
Patch Set 6: (2 comments) Minor comments inline. Thanks! http://gerrit.ovirt.org/#/c/27775/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDaoTest.java: Line 50: public void testGetByClusterIdAndServiceType() { Line 51: GlusterClusterService service = Line 52: dao.getByClusterIdAndServiceType(CLUSTER_ID, ServiceType.GLUSTER); Line 53: assertNotNull(service); Line 54: assertSame(service.getStatus(), GlusterServiceStatus.RUNNING); assertEquals(GlusterServiceStatus.RUNNING, service.getStatus()) ? Line 55: } Line 56: Line 57: @Test Line 58: public void testSave() { http://gerrit.ovirt.org/#/c/27775/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java: Line 96: assertEquals(Long.valueOf(100000), volume.getAdvancedDetails().getCapacityInfo().getTotalSize()); Line 97: assertEquals(Long.valueOf(60000), volume.getAdvancedDetails().getCapacityInfo().getUsedSize()); Line 98: assertEquals(Long.valueOf(40000), volume.getAdvancedDetails().getCapacityInfo().getFreeSize()); Line 99: assertEquals(EXPECTED_DATE_FORMAT.parse(volume.getAdvancedDetails() Line 100: .getUpdatedAt().toString()), EXPECTED_DATE_FORMAT.parse("2014-01-21 18:12:33")); swap expected and actual above? Line 101: } Line 102: Line 103: @Test Line 104: public void testGetAllWithQuery() { -- To view, visit http://gerrit.ovirt.org/27775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bdb907e57b51fcdd8fd8b7a9148273c0304d11 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
