Moti Asayag has posted comments on this change. Change subject: engine: Improve test assert messages ......................................................................
Patch Set 5: Code-Review+1 (5 comments) thanks for the nice patch, we could claim now that there is de-facto static import convention :-) few very minor comments i missed, my +1 regardless of their attendance. http://gerrit.ovirt.org/#/c/27775/5/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/KDCLocatorTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/KDCLocatorTest.java: Line 14: { "0 100 88 example.com.", "0 100 88 comp1.example.com", Line 15: "1 100 88 comp1.example.com." }; Line 16: DnsSRVResult result = locator.getKdc(recordsList, "example.com"); Line 17: int numOfEntries = result.getNumOfValidAddresses(); Line 18: Assert.assertEquals(3, numOfEntries); omit Assert class notation ? Line 19: } http://gerrit.ovirt.org/#/c/27775/5/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfParserTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfParserTest.java: Line 55: thread.join(); Line 56: } Line 57: Line 58: for (Checker checker : checkers) { Line 59: Assert.assertEquals(0, checker.errors); omit Assert. ? Line 60: } Line 61: } Line 62: http://gerrit.ovirt.org/#/c/27775/5/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java: Line 56: VDS vds = new VDS(); Line 57: vds.setSupportedEmulatedMachines("pc-1.0"); Line 58: vds.setStatus(VDSStatus.Up); Line 59: virtStrategy.processSoftwareCapabilities(vds); Line 60: Assert.assertEquals(VDSStatus.Up, vds.getStatus()); omit Assert. ? Line 61: vds.setKvmEnabled(Boolean.TRUE); Line 62: virtStrategy.processSoftwareCapabilities(vds); Line 63: Assert.assertEquals(VDSStatus.Up, vds.getStatus()); Line 64: vds.setKvmEnabled(Boolean.FALSE); Line 59: virtStrategy.processSoftwareCapabilities(vds); Line 60: Assert.assertEquals(VDSStatus.Up, vds.getStatus()); Line 61: vds.setKvmEnabled(Boolean.TRUE); Line 62: virtStrategy.processSoftwareCapabilities(vds); Line 63: Assert.assertEquals(VDSStatus.Up, vds.getStatus()); same here Line 64: vds.setKvmEnabled(Boolean.FALSE); Line 65: virtStrategy.processSoftwareCapabilities(vds); Line 66: assertEquals(VDSStatus.NonOperational, vds.getStatus()); Line 67: } http://gerrit.ovirt.org/#/c/27775/5/backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java File backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java: Line 129: filter.processEvent(new E("message0")); Line 130: filter.processEvent(new E("message1")); Line 131: AuditLogEvent event = smtp.getEvents().get(0); Line 132: String address = smtp.getNames().get(0); Line 133: Assert.assertEquals("message0", event.getName()); omit Assert. ? here and below Line 134: Assert.assertEquals("dbte...@redhat.com", address); Line 135: } Line 136: Line 137: @Test -- To view, visit http://gerrit.ovirt.org/27775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bdb907e57b51fcdd8fd8b7a9148273c0304d11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
