Shireesh Anjal has posted comments on this change. Change subject: engine: Fix for Exception on adding new host ......................................................................
Patch Set 1: I don't quite agree here. Exceptions can be used to indicate validation errors, enabling central handling of such errors, and a cleaner code. I think the overhead of creating an exception is an issue if there are too many such exceptions thrown too frequently, which definitely is not the case with validations. BTW not having any host in UP state in a gluster cluster is a extremely problematic. It can mean that all the servers in the storage cluster are either down or not accessible! Anyway, since you don't like it, we'll change the code to return null and and put the code that checks for null and adds canDoActionError/fault in a common place (probably base class) avoiding too many null checks all over the place. -- To view, visit http://gerrit.ovirt.org/5149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7828145735aa12cd69fa361b947858b535838024 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
