Livnat Peer has posted comments on this change. Change subject: engine: Fix for Exception on adding new host ......................................................................
Patch Set 1: Hi Shireesh, I think that using Exceptions for a standard flow is not a good practice. Exceptions have their overhead, and usually they indicate that something bad happened, I don't consider having no host in up state problematic. Livnat -- To view, visit http://gerrit.ovirt.org/5149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7828145735aa12cd69fa361b947858b535838024 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
