Omer Frenkel has posted comments on this change.
Change subject: engine: Adding brick order to Gluster volume bricks
......................................................................
Patch Set 9: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
Line 22: private GlusterVolumeEntity volume;
what is the difference between this field and AuditLogableBase.glusterVolume ?
why have another field? i think its possible to use only getGlusterVolume()
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
Line 210: if (replicaCount < 2) {
maybe thats for another patch but consider make these numbers configurable or
at least constants in GlusterCoreUtil or somewhere central for "hard-coded"
values
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
Line 40: private Integer brickOrder;
can this be null? if not, change to int
--
To view, visit http://gerrit.ovirt.org/4939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bce4cf0b75c49b4ab20494c48a012b0bd3d55f6
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
