Selvasundaram has posted comments on this change.
Change subject: engine: Adding brick order to Gluster volume bricks
......................................................................
Patch Set 5: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
Line 144: (getParameters().getReplicaCount() == 0 ||
getParameters().getReplicaCount() == volume.getReplicaCount())
Ok. Removed the || condition.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java
Line 39: .addValue("new_brick_order",
oldBrick.getBrickOrder())
Removed from here and sp.
Line 101:
brick.setBrickOrder(Integer.parseInt(rs.getString("brick_order")));
Done
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1856: String ACTION_TYPE_FAILED_REPLICA_COUNT_MIN_4();
Done
Line 1860:
Done
--
To view, visit http://gerrit.ovirt.org/4939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bce4cf0b75c49b4ab20494c48a012b0bd3d55f6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
