Sandro Bonazzola has posted comments on this change. Change subject: packaging: allow to override sos version ......................................................................
Patch Set 5: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/27691/5/configure.ac File configure.ac: Line 71: [AS_HELP_STRING([--with-sos-version], [sos version to use])], Line 72: [SOS_VERSION="${withval}"], Line 73: [ Line 74: AX_PYTHON_MODULE([sos], [fatal]) Line 75: SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__)" |cut -c1 2>/dev/null)" Checked autogen.sh output: configure.ac has: SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__.split('.', 2)[0])" 2>/dev/null)" which is translated in configure as: SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__.split('.', 2)0)" 2>/dev/null)" Adding \ escaping: SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__.split('.', 2)\0\)" 2>/dev/null)" looks like [ and ] can't be used there or there's a different escaping sequence. Line 76: ] Line 77: ) Line 78: Line 79: AC_MSG_CHECKING([sos version]) -- To view, visit http://gerrit.ovirt.org/27691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6cd685f5bf7f7c1b49dc769e46bb6aa3adfff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
