Alon Bar-Lev has posted comments on this change. Change subject: packaging: allow to override sos version ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27691/4/configure.ac File configure.ac: Line 70: AC_ARG_WITH( Line 71: [sos-version], Line 72: [AS_HELP_STRING([--with-sos-version], [sos version to use])], Line 73: [SOS_VERSION="${withval}"], Line 74: [SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__)" |cut -c1 2>/dev/null)"] > using suggeested split doesn't work: this is strange! there should be no difference, you can quote anything within the quotes, something else is wrong, please just add a print of what you get. also, no that I can see that you should not check for module if you have version.. provided. AC_ARG_WITH( [sos-version], [AS_HELP_STRING([--with-sos-version], [sos version to use])], [SOS_VERSION="${withval}"], [ AX_PYTHON_MODULE([sos], [fatal]) SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__)" |cut -c1 2>/dev/null)" ] ) or at least check this non fatal Line 75: ) Line 76: AC_MSG_RESULT($SOS_VERSION) Line 77: Line 78: AM_CONDITIONAL([SOS2], [test x"${SOS_VERSION}" == x2]) -- To view, visit http://gerrit.ovirt.org/27691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6cd685f5bf7f7c1b49dc769e46bb6aa3adfff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
