Eli Mesika has posted comments on this change. Change subject: db: aggregate qos and storage qos impl ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27094/6/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 210: select fn_db_add_config_value('NetworkQosSupported','false','3.2'); Line 211: select fn_db_add_config_value('StorageQosSupported','false','3.0'); Line 212: select fn_db_add_config_value('StorageQosSupported','false','3.1'); Line 213: select fn_db_add_config_value('StorageQosSupported','false','3.3'); Line 214: select fn_db_add_config_value('StorageQosSupported','false','3.4'); Please consider change that to a 'general' config key , it has the same value cross versions Also, please note that current config already has 3.5 entries Line 215: select fn_db_add_config_value('HostNetworkQosSupported', 'false', '3.0'); Line 216: select fn_db_add_config_value('HostNetworkQosSupported', 'false', '3.1'); Line 217: select fn_db_add_config_value('HostNetworkQosSupported', 'false', '3.2'); Line 218: select fn_db_add_config_value('HostNetworkQosSupported', 'false', '3.3'); -- To view, visit http://gerrit.ovirt.org/27094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
