Juan Hernandez has posted comments on this change. Change subject: packaging: Block 3.1 upgrade if DC/cluster 2.2 present ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 80: MSG_ERROR_CONNECT_DB = "Error: failed to connect to postgres DB" Minor: I would do some cosmetic changes to this message: "Error: Failed to connect to database". I prefer to avoid using the name of the database, that way if one day we use a different database you don't have to change the message. -- To view, visit http://gerrit.ovirt.org/5186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0277b73628872e8c0fa163fee0b89bd5cb724f05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
