Omer Frenkel has posted comments on this change. Change subject: core: long query response time while many simultaneously queries are running ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/27586/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java: Line 112: getCallsHandler().executeModification("UpdateStatusOfImagesByImageGroupId", parameterSource); Line 113: } Line 114: Line 115: @Override Line 116: public Map<Guid, Guid> getImageGroupIdMapForImageList(List<Guid> requiredDisks) { please add test Line 117: try (Connection c = jdbcTemplate.getDataSource().getConnection()) { Line 118: Array imageArray = c.createArrayOf("uuid", requiredDisks.toArray()); Line 119: Line 120: List<ImageAndImageGroupId> disks = getCallsHandler().executeReadList("GetImageGroupByImageId", http://gerrit.ovirt.org/#/c/27586/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1617: // compare between vm in cache and vm from vdsm Line 1618: removeVmsFromCache(staleRunningVms); Line 1619: } Line 1620: Line 1621: private Map<Guid, Guid> loadImageGroupsIdsIfNeeded(List<Guid> requiredDisks) { why not move all related code into the method? and then collect all id's only if you actually need them? Line 1622: if (_vdsManager.getRefreshStatistics()) Line 1623: return getDbFacade().getImageDao().getImageGroupIdMapForImageList(requiredDisks); Line 1624: Line 1625: return new HashMap<>(); -- To view, visit http://gerrit.ovirt.org/27586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
