Omer Frenkel has posted comments on this change. Change subject: core: long query response time while many simultaneously queries are running ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27586/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1518: for (DiskImageDynamic disk : vmInternalData.getVmDynamic().getDisks()) { Line 1519: requiredDisks.add(disk.getId()); Line 1520: } Line 1521: } Line 1522: Map<Guid, Guid> diskImages = getDbFacade().getImageDao().getImageIdForDisks(requiredDisks); > can you place code above the call the updateVmStatistics? its too early in well i guess it have to be outside of the for loop, as this is a one-time call, but we need this only on statistics cycle (5th) not every cycle, so please: first, extract this to a method. then call this only if _vdsManager.getRefreshStatistics() another option is to do lazy evaluation and call it from updateVmStatistics: private Guid getActiveImageId(id) { if (requiredDisks == null) { populate requiredDisks; } return requiredDisks.get(id) } Line 1523: for (VmInternalData vmInternalData : _runningVms.values()) { Line 1524: VmDynamic runningVm = vmInternalData.getVmDynamic(); Line 1525: VM vmToUpdate = _vmDict.get(runningVm.getId()); Line 1526: -- To view, visit http://gerrit.ovirt.org/27586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
