Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Introduce plugin for fence_kdump listener ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27486/2/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 926: %config %{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging.conf Line 927: %{_bindir}/engine-upgrade-check Line 928: %{engine_data}/conf/ovirt-engine-proxy.conf.v2.in Line 929: %{engine_data}/conf/ovirt-engine-root-redirect.conf.in Line 930: %{engine_data}/firewalld/fence-kdump-listener/ so this should be removed Line 931: %{engine_data}/firewalld/ovirt-engine/ Line 932: %{engine_data}/setup/bin/ovirt-engine-rename Line 933: %{engine_data}/setup/bin/ovirt-engine-upgrade-check Line 934: %{engine_data}/setup/dbutils/ Line 931: %{engine_data}/firewalld/ovirt-engine/ Line 932: %{engine_data}/setup/bin/ovirt-engine-rename Line 933: %{engine_data}/setup/bin/ovirt-engine-upgrade-check Line 934: %{engine_data}/setup/dbutils/ Line 935: %{engine_data}/setup/plugins/*/fence_kdump_listener/ this can be within ovirt-engine, no need to modify spec. Line 936: %{engine_data}/setup/plugins/*/ovirt-engine/ Line 937: %{engine_data}/setup/plugins/ovirt-engine-rename/ Line 938: Line 939: # backward compatibility http://gerrit.ovirt.org/#/c/27486/2/packaging/setup/plugins/ovirt-engine-setup/fence_kdump_listener/config.py File packaging/setup/plugins/ovirt-engine-setup/fence_kdump_listener/config.py: Line 120: 'value': self.environment[ Line 121: osetupcons.ConfigEnv.FENCE_KDUMP_LISTENER_PORT Line 122: ], Line 123: }, Line 124: ), if we move this to config file, we can drop most of this plugin... as people can just edit the service configuration post setup, and default is sufficient in 99% of cases. Line 125: ) Line 126: Line 127: @plugin.event( Line 128: stage=plugin.Stages.STAGE_CLOSEUP, -- To view, visit http://gerrit.ovirt.org/27486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
