Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Introduce plugin for fence_kdump listener ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/27486/5/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 77: OVIRT_ENGINE_SERVICE_CONFIG = config.ENGINE_SERVICE_CONFIG Line 78: OVIRT_ENGINE_SERVICE_CONFIG_DEFAULTS = \ Line 79: config.ENGINE_SERVICE_CONFIG_DEFAULTS Line 80: OVIRT_ENGINE_FENCE_KDUMP_LISTENER_CONFIG = \ Line 81: config.ENGINE_FENCE_KDUMP_LISTENER_CONFIG no need Line 82: OVIRT_ENGINE_WEBSOCKET_PROXY_CONFIG = config.ENGINE_WEBSOCKET_PROXY_CONFIG Line 83: OVIRT_ENGINE_NOTIFIER_SERVICE_CONFIG = \ Line 84: config.ENGINE_NOTIFIER_SERVICE_CONFIG Line 85: OVIRT_ENGINE_OSINFO_REPOSITORY_DIR = os.path.join( Line 523: DB_SCHEMA = 'osetup.db.schema' Line 524: NET_FIREWALL_MANAGER_AVAILABLE = 'osetup.net.firewallmanager.available' Line 525: CONFIG_PROTOCOLS_CUSTOMIZATION = 'osetup.config.protocols.customization' Line 526: CONFIG_FENCE_KDUMP_LISTENER_CUSTOMIZATION = \ Line 527: 'setup.config.fence-kdump-listener.customization' no need Line 528: CONFIG_WEBSOCKET_PROXY_CUSTOMIZATION = \ Line 529: 'setup.config.websocket-proxy.customization' Line 530: CONFIG_DB_ENCRYPTION_AVAILABLE = 'osetup.config.encryption.available' Line 531: CONFIG_APPLICATION_MODE_AVAILABLE = \ Line 874: JBOSS_HTTPS_PORT = 'OVESETUP_CONFIG/jbossHttpsPort' Line 875: JBOSS_AJP_PORT = 'OVESETUP_CONFIG/jbossAjpPort' Line 876: JBOSS_DIRECT_HTTP_PORT = 'OVESETUP_CONFIG/jbossDirectHttpPort' Line 877: JBOSS_DIRECT_HTTPS_PORT = 'OVESETUP_CONFIG/jbossDirectHttpsPort' Line 878: FENCE_KDUMP_LISTENER_PORT = 'OVESETUP_CONFIG/fenceKdumpListenerPort' no need Line 879: WEBSOCKET_PROXY_PORT = 'OVESETUP_CONFIG/websocketProxyPort' Line 880: JBOSS_DEBUG_ADDRESS = 'OVESETUP_CONFIG/jbossDebugAddress' Line 881: ADD_OVIRT_GLANCE_REPOSITORY = 'OVESETUP_CONFIG/addOvirtGlanceRepository' Line 882: http://gerrit.ovirt.org/#/c/27486/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py: Line 88: ].update({ Line 89: '@FENCE_KDUMP_LISTENER_PORT@': self.environment[ Line 90: osetupcons.ConfigEnv.FENCE_KDUMP_LISTENER_PORT Line 91: ], Line 92: }) if we allow override port, we need to write config with that port. Line 93: Line 94: @plugin.event( Line 95: stage=plugin.Stages.STAGE_CLOSEUP, Line 96: condition=lambda self: ( -- To view, visit http://gerrit.ovirt.org/27486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
