Ori Liel has posted comments on this change. Change subject: rest: Add support for REST to get all the unregistered entities ......................................................................
Patch Set 13: Code-Review+2 (2 comments) Looks great, +2, preferably revert unnecessary whitespace changes. http://gerrit.ovirt.org/#/c/26483/13/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java: Line 59: validateParameters(action, "cluster.id|name", "storageDomain.id|name"); Line 60: Guid destStorageDomainId = getDestStorageDomainId(action); Line 61: Line 62: ImportVmParameters params = new ImportVmParameters(getEntity(), Line 63: parent.getStorageDomainId(), whitespace Line 64: destStorageDomainId, Line 65: parent.getDataCenterId(destStorageDomainId), Line 66: getClusterId(action)); Line 67: params.setImageToDestinationDomainMap(getDiskToDestinationMap(action)); Line 73: } Line 74: Line 75: if (action.isSetClone()) { Line 76: params.setImportAsNewEntity(action.isClone()); Line 77: if (action.isSetVm() && action.getVm().isSetName()) { whitespace Line 78: params.getVm().setName(action.getVm().getName()); Line 79: } Line 80: } Line 81: -- To view, visit http://gerrit.ovirt.org/26483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4a020c4c653b0fafed16c1d29924223f9b2879f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
