Ori Liel has posted comments on this change. Change subject: rest: Add support for REST to get all the unregistered entities ......................................................................
Patch Set 12: (5 comments) http://gerrit.ovirt.org/#/c/26483/12/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1502: signatures: [] Line 1503: urlparams: {} Line 1504: headers: {} Line 1505: - name: /storagedomains/{storagedomain:id}/templates/{template:id}/register|rel=register Line 1506: description: Register the template from the data domain Please elaborate. This operation should be used in very specific circumstances, it could be useful to explain them here. Line 1507: request: Line 1508: body: Line 1509: parameterType: Action Line 1510: signatures: Line 1571: signatures: [] Line 1572: urlparams: {} Line 1573: headers: {} Line 1574: - name: /storagedomains/{storagedomain:id}/vms/{vm:id}/register|rel=register Line 1575: description: Register the VM from the data domain Please elaborate. This operation should be used in very specific circumstances, it could be useful to explain them here. Line 1576: request: Line 1577: body: Line 1578: parameterType: Action Line 1579: signatures: http://gerrit.ovirt.org/#/c/26483/12/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java: Line 38: return addLinks(populate(map(entity, null), entity), null, new String[0]); Line 39: } Line 40: Line 41: @Override Line 42: public Response register(Action action) { same comments as for BackendStorageDomainVmResource Line 43: validateParameters(action, "cluster.id|name"); Line 44: ImportVmTemplateParameters params = new ImportVmTemplateParameters(); Line 45: params.setContainerId(guid); Line 46: params.setVdsGroupId(getClusterId(action)); http://gerrit.ovirt.org/#/c/26483/12/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java: Line 39: @Override Line 40: public Response register(Action action) { Line 41: validateParameters(action, "cluster.id|name"); Line 42: ImportVmParameters params = new ImportVmParameters(); Line 43: params.setContainerId(guid); Why is it called 'Container id'? Line 44: params.setVdsGroupId(getClusterId(action)); Line 45: params.setImagesExistOnStorageDomain(true); Line 46: Line 47: if (action.isSetClone()) { Line 45: params.setImagesExistOnStorageDomain(true); Line 46: Line 47: if (action.isSetClone()) { Line 48: params.setImportAsNewEntity(action.isClone()); Line 49: if (action.isSetVm() && action.getVm().isSetName()) { Is VM name only relevant when clone=true? If so, there should be two separate signatures in rsdl_metadata.yaml Line 50: params.getVm().setName(action.getVm().getName()); Line 51: } Line 52: } Line 53: -- To view, visit http://gerrit.ovirt.org/26483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4a020c4c653b0fafed16c1d29924223f9b2879f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
