Yair Zaslavsky has posted comments on this change. Change subject: aaa: add authz namespace support ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27538/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 183: Base.InvokeKeys.COMMAND, Line 184: Authz.InvokeCommands.QUERY_OPEN Line 185: ).mput( Line 186: Authz.InvokeKeys.NAMESPACE, Line 187: namespace the key expects ExtUUID Line 188: ).mput( Line 189: input Line 190: ) Line 191: ).get(Authz.InvokeKeys.QUERY_OPAQUE); http://gerrit.ovirt.org/#/c/27538/1/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java: Line 54: /** Line 55: * Namespace to use. Line 56: * @see ContextKeys#AVAILABLE_NAMESPACES Line 57: */ Line 58: public static final ExtKey NAMESPACE = new ExtKey("AAA_AUTHZ_NAMESPACE", ExtUUID.class, "7e12d802-86ff-4162-baaa-d6f6fe73201e"); Shouldn't this be string? Line 59: /** Line 60: * Query filter. Line 61: * @see QueryFilterRecord Line 62: */ -- To view, visit http://gerrit.ovirt.org/27538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38968ae4b61aa8d0a5120a22a17e016cbe96c5e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
