Yair Zaslavsky has posted comments on this change. Change subject: aaa: add authz namespace support ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27538/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 204: ).get(Authz.InvokeKeys.QUERY_RESULT); Line 205: } while (result != null && handler.handle(result)); Line 206: Line 207: // no conditional in for-in Line 208: if (result != null) { > it means that the handle requested to stop loop, no? The handler requested to stop the for loop? Why arent u continuing to the next namespace in this case? (maybe some lack of knowledge from my side... so i'm asking). Line 209: break; Line 210: } Line 211: } Line 212: } finally { -- To view, visit http://gerrit.ovirt.org/27538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38968ae4b61aa8d0a5120a22a17e016cbe96c5e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
