Gilad Chaplik has posted comments on this change. Change subject: engine: Numa feature entities ......................................................................
Patch Set 27: (2 comments) http://gerrit.ovirt.org/#/c/23702/27/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java: Line 21: Line 22: /** Line 23: * @return vNUMA node pair list; first is the pNUMA node index, second is boolean for pinned or not (TRUE=pinned) Line 24: */ Line 25: public List<Pair<Integer, Boolean>> getVdsNumaNodeList() { > Do you mean pNuma(uuid), Boolean(ispinned), index(pNuma index)? If you want in case the vm is not pinned to host (migratable), we would like to pin vnode to pnode index and not to pnode uuid. I'd go for list as structure (array list). Line 26: return vdsNumaNodeList; Line 27: } Line 28: Line 29: public void setVdsNumaNodeList(List<Pair<Integer, Boolean>> vdsNumaNodeList) { http://gerrit.ovirt.org/#/c/23702/27/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java: Line 70: setDefaultBootSequence(BootSequence.C); Line 71: setDefaultDisplayType(DisplayType.qxl); Line 72: setVmType(VmType.Desktop); Line 73: vmtGuid = Guid.Empty; Line 74: setNumaTuneMode(NumaTuneMode.PREFERRED); > This is suggested by Vinod. Strict means if vNode pinned to pNode, then the Done Line 75: vNumaNodeList = new ArrayList<VmNumaNode>(); Line 76: } Line 77: Line 78: public VmStatic(VmStatic vmStatic) { -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
