Xiaolei Shi has posted comments on this change. Change subject: engine: Numa feature entities ......................................................................
Patch Set 27: (3 comments) http://gerrit.ovirt.org/#/c/23702/27/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java: Line 10: /** Line 11: * Object which represents host NUMA node information Line 12: * Line 13: */ Line 14: public class VdsNumaNode extends IVdcQueryable implements BusinessEntity<Guid> { > I think it should also implement Serializable iface explicitly, its a GWT i Done Line 15: Line 16: private static final long serialVersionUID = -683066053231559224L; Line 17: Line 18: private Guid id; http://gerrit.ovirt.org/#/c/23702/27/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java: Line 21: Line 22: /** Line 23: * @return vNUMA node pair list; first is the pNUMA node index, second is boolean for pinned or not (TRUE=pinned) Line 24: */ Line 25: public List<Pair<Integer, Boolean>> getVdsNumaNodeList() { > should be a triplet of pNuma, Boolean and index. please read comments in da Do you mean pNuma(uuid), Boolean(ispinned), index(pNuma index)? If you want this strcture, i will modify like what you said. But i think don't need to add index in map table. In map table, we stored the uuid of pnode and vnode, we can get any fields(like index) of numa node from view(See my dao comments against your comments). Line 26: return vdsNumaNodeList; Line 27: } Line 28: Line 29: public void setVdsNumaNodeList(List<Pair<Integer, Boolean>> vdsNumaNodeList) { http://gerrit.ovirt.org/#/c/23702/27/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java: Line 70: setDefaultBootSequence(BootSequence.C); Line 71: setDefaultDisplayType(DisplayType.qxl); Line 72: setVmType(VmType.Desktop); Line 73: vmtGuid = Guid.Empty; Line 74: setNumaTuneMode(NumaTuneMode.PREFERRED); > why you changed the default? don't know why but that's an interesting quest This is suggested by Vinod. Strict means if vNode pinned to pNode, then the vNode can only use the pNode's memory, if no enough memory, the memory request will failed. Preferred means if will first use the memory of the pinned pNode, if no enough memory, it will request other pNode's memory. Maybe preferred is more safe to the business i think. Line 75: vNumaNodeList = new ArrayList<VmNumaNode>(); Line 76: } Line 77: Line 78: public VmStatic(VmStatic vmStatic) { -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
