Alon Bar-Lev has posted comments on this change. Change subject: packaging: Introduce setup plugin to configure fence_kdump listener ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27486/1/packaging/setup/plugins/ovirt-engine-setup/fence_kdump_listener/config.py File packaging/setup/plugins/ovirt-engine-setup/fence_kdump_listener/config.py: Line 196: state=state, Line 197: ) Line 198: self.services.startup( Line 199: name=osetupcons.Const.FENCE_KDUMP_LISTENER_SERVICE_NAME, Line 200: state=True, > I think, it should be started always. well, with all of the respect to this software, if sysadmin selects this to be stopped, we should not override his decision, he probably do not use this service. Line 201: ) Line 202: Line 203: -- To view, visit http://gerrit.ovirt.org/27486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
