Shirly Radco has posted comments on this change. Change subject: reports: br10c report - added comments to queries ......................................................................
Patch Set 3: (7 comments) http://gerrit.ovirt.org/#/c/26666/3/packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data: Line 202: '*' Line 203: END AS disk_name, Line 204: CAST ( Line 205: EXTRACT ( HOUR FROM history_datetime ) AS int Line 206: ) AS Time, > This should be indented by one less tab Done Line 207: MAX Line 208: ( Line 209: ROUND ( Line 210: CAST ( Line 204: CAST ( Line 205: EXTRACT ( HOUR FROM history_datetime ) AS int Line 206: ) AS Time, Line 207: MAX Line 208: ( > Please move up a line and align columns names Done Line 209: ROUND ( Line 210: CAST ( Line 211: COALESCE ( Line 212: read_rate_bytes_per_second, Line 217: 1 Line 218: ) Line 219: ) AS Read_Rate, Line 220: MAX Line 221: ( > Please move up a line and align columns names Done Line 222: ROUND ( Line 223: CAST ( Line 224: COALESCE ( Line 225: write_rate_bytes_per_second, Line 376: ), Line 377: disk_name Line 378: ORDER BY Line 379: CAST ( Line 380: EXTRACT ( HOUR FROM $P!{calendar_column} ) AS int > This is not indented correctly Done Line 381: ), Line 382: COALESCE ( Line 383: disk_name, Line 384: MAX ( disk_name ) over ( partition by 1 ), Line 452: '*' Line 453: END AS interface_name, Line 454: CAST ( Line 455: EXTRACT ( HOUR FROM history_datetime ) AS int Line 456: ) AS time, > this need to be one tab less Done Line 457: AVG ( Line 458: COALESCE ( Line 459: receive_rate_percent, Line 460: 0 Line 582: ) AS a Line 583: RIGHT OUTER JOIN calendar AS b Line 584: ON ( Line 585: a.time = Line 586: CAST ( > move one line up and reorder Done Line 587: EXTRACT ( HOUR FROM b.$P!{calendar_column} ) AS int Line 588: ) Line 589: ) Line 590: WHERE b.$P!{calendar_column} >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 604: EXTRACT ( HOUR FROM $P!{calendar_column} ) AS int Line 605: ), Line 606: interface_name Line 607: ORDER BY Line 608: CAST ( > this need to be one tab less Done Line 609: EXTRACT ( HOUR FROM $P!{calendar_column} ) AS int Line 610: ) ASC]]> Line 611: </queryString> Line 612: <field name="hour_num" class="java.lang.Integer"/> -- To view, visit http://gerrit.ovirt.org/26666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7a8fc189ba26b2bbb3a4bb8834e0ec2a14c7a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
