Yaniv Dary has posted comments on this change. Change subject: reports: br10c report - added comments to queries ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/26666/2/packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data: Line 287: WHEN $P{P_Period} = 3 Line 288: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 year' Line 289: END Line 290: AND ( Line 291: delete_date <= CAST ( $P{P_Start_Date} AS TIMESTAMP ) This should be '>=', no? Line 292: OR Line 293: delete_date IS NULL Line 294: ) Line 295: -- Here we get the latest vms devices configuration Line 465: transmit_rate_percent, Line 466: 0 Line 467: ) Line 468: ) AS Tx_rate Line 469: FROM v3_4_statistics_vms_interfaces_resources_usage_$P!{table_name} This should be indented by one more tab Line 470: INNER JOIN v3_4_configuration_history_vms_interfaces Line 471: ON ( Line 472: v3_4_configuration_history_vms_interfaces.vm_interface_id = Line 473: v3_4_statistics_vms_interfaces_resources_usage_$P!{table_name}.vm_interface_id Line 524: WHEN $P{P_Period} = 3 Line 525: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 year' Line 526: END Line 527: AND ( Line 528: delete_date <= CAST ( $P{P_Start_Date} AS TIMESTAMP ) same Line 529: OR Line 530: delete_date IS NULL Line 531: ) Line 532: -- Here we get the latest vms devices configuration Line 583: RIGHT OUTER JOIN calendar Line 584: ON ( Line 585: a.time = Line 586: CAST ( Line 587: EXTRACT ( HOUR FROM b.$P!{calendar_column} ) AS int This is not correctly indented. either merge or drop line. Line 588: ) Line 589: WHERE b.$P!{calendar_column} >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 590: AND b.$P!{calendar_column} < Line 591: CASE -- To view, visit http://gerrit.ovirt.org/26666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7a8fc189ba26b2bbb3a4bb8834e0ec2a14c7a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
