Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Support column sorting ......................................................................
Patch Set 7: This patchset should fix FindBugs warning for "SortSensitiveComparator.compare" method returning negated value of "comparator.compare" method. In Java world, int is 32bit signed integral type (-2147483648 to 2147483647) and negating its minimum value yields unexpected result. This is why FindBugs issues warning mentioned above. In JavaScript world, there's just one numerical type - number, which is 64bit signed floating point type, similar to double in Java world. Since GWT emulates Java's different numerical types through JavaScript number type, the FindBugs warning mentioned above is not relevant in practice. -- To view, visit http://gerrit.ovirt.org/25910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I141ea068fe90409852d34bea6fedb45d0d8a07ae Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
