Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Support column sorting ......................................................................
Patch Set 6: Verified+1 (4 comments) This patch is now ready for final review. Notable changes in this patchset: * fixed client-side sorting not taking sort direction into account * improved SortedListModel for general use, dealing with Comparator and item sorting * modified SearchableListModel to extend SortedListModel, including setComparator method override to retain current behavior Verified that both server-side and client-side sorting works for given columns: * DataCenters main tab --> Name column (server-side) * DataCenters main tab | Clusters sub tab --> Name column (client-side) This patch reverts some changes done by http://gerrit.ovirt.org/#/c/26581/ in order to avoid conflicts with sort icon handling in GWT CellTable. Patch http://gerrit.ovirt.org/#/c/27079/ (rebased on this one) will address the issue of resize user experience that is consistent with column sort implementation. http://gerrit.ovirt.org/#/c/25910/6/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolFieldAutoCompleter.java: Line 1: package org.ovirt.engine.core.searchbackend; Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.StoragePoolStatus; Line 4: Line 5: public class StoragePoolFieldAutoCompleter extends BaseConditionFieldAutoCompleter { Changes in this file are only to demonstrate column sort feature and will be reverted before merging the patch. Line 6: public static final String NAME = "NAME"; Line 7: Line 8: public StoragePoolFieldAutoCompleter() { Line 9: // Building the basic vervs Dict http://gerrit.ovirt.org/#/c/25910/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java: Line 58: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs; Line 59: import org.ovirt.engine.ui.uicompat.UIConstants; Line 60: Line 61: @SuppressWarnings("unused") Line 62: public class DataCenterListModel extends ListWithDetailsModel implements ISupportSystemTreeContext Changes in this file are only to demonstrate column sort feature and will be reverted before merging the patch. Line 63: { Line 64: Line 65: private UICommand privateNewCommand; Line 66: http://gerrit.ovirt.org/#/c/25910/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java: Line 28: Line 29: import com.google.gwt.core.client.GWT; Line 30: import com.google.inject.Inject; Line 31: Line 32: public class MainTabDataCenterView extends AbstractMainTabWithDetailsTableView<StoragePool, DataCenterListModel> implements MainTabDataCenterPresenter.ViewDef { Changes in this file are only to demonstrate column sort feature and will be reverted before merging the patch. Line 33: Line 34: interface ViewIdHandler extends ElementIdHandler<MainTabDataCenterView> { Line 35: ViewIdHandler idHandler = GWT.create(ViewIdHandler.class); Line 36: } http://gerrit.ovirt.org/#/c/25910/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java: Line 13: import org.ovirt.engine.ui.webadmin.ApplicationConstants; Line 14: import org.ovirt.engine.ui.webadmin.section.main.presenter.tab.datacenter.SubTabDataCenterClusterPresenter; Line 15: import org.ovirt.engine.ui.webadmin.section.main.view.AbstractSubTabTableView; Line 16: Line 17: public class SubTabDataCenterClusterView extends AbstractSubTabTableView<StoragePool, VDSGroup, DataCenterListModel, DataCenterClusterListModel> Changes in this file are only to demonstrate column sort feature and will be reverted before merging the patch. Line 18: implements SubTabDataCenterClusterPresenter.ViewDef { Line 19: Line 20: @Inject Line 21: public SubTabDataCenterClusterView(SearchableDetailModelProvider<VDSGroup, DataCenterListModel, DataCenterClusterListModel> modelProvider, ApplicationConstants constants) { -- To view, visit http://gerrit.ovirt.org/25910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I141ea068fe90409852d34bea6fedb45d0d8a07ae Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
